Add support for :sudo service property

rejeep / prodigy.el

Manage external services from within Emacs

GNU General Public License v3.0

550 stars 39 forks source link

Add support for :sudo service property #102

Closed felipeochoa closed 6 years ago

felipeochoa commented 7 years ago

I've taken a first stab at adding sudo (#29) support by calling the process through the shell. You can see the results here. This PR only includes support for the :sudo prop, not for :sudo-user, as you'd originally specified.

If you approve of the approach I'll add some unit tests to get this merged.

Todos:

[X] Implement :sudo functionality
[X] Add unit test for sudo services
[X] Update docstring for prodigy-services

felipeochoa commented 7 years ago

@rejeep I've added a test for the :sudo functionality. I've also been using this for the past two weeks without issue. Let me know if it looks good to merge

felipeochoa commented 6 years ago

@rejeep bump!

rejeep commented 6 years ago

@felipeochoa Code looks nice and tidy and I trust you have verified that it works, merging. Thanks for the contribution!

felipeochoa commented 6 years ago

@rejeep Thanks!