Closed xuchunyang closed 4 years ago
I'm not sure exactly what this would mean in practice? Also, I don't use the hook so it's difficult for me to verify.
The hook is added once you have invoked M-x prodigy
. Since it's not added locally, prodigy-set-default-directory
will be called even you're outside the *prodigy*
buffer.
How to reproduce:
M-x prodigy
and kill the buffer *prodigy*
C-h v post-command-hook
and you should notice prodigy-set-default-directory
is in the global valueAhh, now I see what you mean. I was a bit quick the first time and thought this was a mode hook for Prodigy. I also see that prodigy-set-default-directory
checks the major mode, so it shouldn't be that much of an issue, but I agree it's better to not pollute the global state.
I added you as a collaborator, so feel free to merge.
Thanks! 👍
Thanks. I notice the travis ci is failing but it's a Cask issue, so I've merged this pr.
I think the hook is ment to re-set the default directory when you change the active row (iow set it to that process's dd). :+1:
It seems
prodigy-set-default-directory
is no use outside the prodigy buffer.