search

rejeep / prodigy.el

Manage external services from within Emacs
GNU General Public License v3.0
550 stars 39 forks source link

Make it possible to store a function in :url #135

Closed DamienCassou closed 2 years ago

DamienCassou commented 2 years ago

This is useful when the default URL (format "http://localhost:%d" port) or a plain string don't work. For example, the URL must contain the PORT and a path (format "http://localhost:%d/foo/bar" port)

A simpler but less powerful solution would be to add a new :url-path property which could just be "/foo/bar" in the example above.

rejeep commented 2 years ago

Hi @DamienCassou, I added you as a collaborator, feel free to contribute!

DamienCassou commented 2 years ago

feel free to contribute!

what do you mean exactly by that? I thought I was contributing already :-).

Do you want me to merge my own PRs without you double-checking? I would prefer a code review first if possible.

rejeep commented 2 years ago

I don't maintain my Emacs packages anymore so when people create pull requests I typically give them commit access (if I feel it's a credible enough person). If someone else wants to review that's obviously good.

DamienCassou commented 2 years ago

I don't maintain my Emacs packages anymore so when people create pull requests I typically give them commit access (if I feel it's a credible enough person). If someone else wants to review that's obviously good.

Very good. I'm taking over maintenance. I'm sad you left though. Thank you very much for all your hard work and excellent packages.

rejeep commented 2 years ago

Glad to hear you are taking over, thanks! 👍