search

rejetto / hfs

HFS is a web file server to run on your computer. Share folders or even a single file thanks to the virtual file system.
GNU General Public License v3.0
2.29k stars 227 forks source link

Update Vietnamese to 0.51.0 #525

Closed BussyBakks closed 8 months ago

BussyBakks commented 8 months ago

@rejetto image

rejetto commented 8 months ago

i see that you are changing "vi" to "vn". I just checked and found that MDN states the codes must refer to document RFC 5646, that in turn refer to ISO 639, that reports for vietnamese "vi", not "vn". So, this request for change seems to be wrong. I know that "vn" is used for domains, but that's a different standard. Do you have any comment on this?

rejetto commented 8 months ago

i see that (other than rename) you also made several additions and fixes. don't worry, these won't be lost. they will be included in next release.

BussyBakks commented 8 months ago

i see that you are changing "vi" to "vn". I just checked and found that MDN states the codes must refer to document RFC 5646, that in turn refer to ISO 639, that reports for vietnamese "vi", not "vn". So, this request for change seems to be wrong. I know that "vn" is used for domains, but that's a different standard. Do you have any comment on this?

uh yeah i forgot "vn" is domain i will fix soon

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

BussyBakks commented 8 months ago

@rejetto i fixed my work

rejetto commented 8 months ago

ok thanks, i will include it in 0.52, tho

rejetto commented 8 months ago

you may want to consider strings for 0.52 https://github.com/rejetto/hfs/discussions/402#discussioncomment-8747957