search

rejuvena / collate

tModLoader ModCompile alternative with extra features.
https://tomat.dev/projects/terraria/rejuvena/collate
GNU General Public License v2.0
7 stars 3 forks source link

[Bug] [Critical] Packaging Fails in Visual Studio #1

Closed steviegt6 closed 1 year ago

steviegt6 commented 2 years ago

The mod packaging task from Collate fails in Visual Studio, but functions fine through the dotnet CLI tool and through Rider.

A sample exception:

The "PackageModTask" task could not be loaded from the assembly C:\Users\User\.nuget\packages\rejuvena.collate\1.0.1\build\Rejuvena.Collate.dll.
Could not load file or assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.
ResourcePatcher C:\Users\User\.nuget\packages\rejuvena.collate\1.0.1\build\Rejuvena.Collate.targets 89
Tabizzz commented 2 years ago

The "PackageModTask" task could not be loaded from the assembly C:\Users\User\.nuget\packages\rejuvena.collate\1.0.1\build\Rejuvena.Collate.dll. Could not load file or assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. ResourcePatcher C:\Users\User\.nuget\packages\rejuvena.collate\1.0.1\build\Rejuvena.Collate.targets 89

steviegt6 commented 2 years ago

Likely an issue with how I package the library, maybe an issue with the fact I'm including Rejuvena.Collate.deps.json?

steviegt6 commented 1 year ago

I believe this has been resolved in an unreleased build.

steviegt6 commented 1 year ago

As far as I'm aware, resolved in f48f6df6f1b13a25337ad19faf58ae6e4cdce052 and c2d57be61860f5401f2d40cb0fdc2548c554d839.