search

rejuvenate / lovelace-horizon-card

Sun Card successor: Visualize the position of the Sun over the horizon.
MIT License
438 stars 30 forks source link

Wrong Portuguese from Portugal translation #135

Open jfreves opened 3 months ago

jfreves commented 3 months ago

When setting up the language with pt (Portuguese from Portugal) the translation for moonrise and moonset is not correct, it is using dawn and dusk translations which are not correct.

image 
"dawn": "Amanhecer",
"dusk": "Anoitecer",
"elevation": "Elevação",
"moonrise": "Anoitecer",
"moonset": "Amanhecer",

It seems that was already a PR with the correct translation but was dismissed for some reason.

It would made more sense to remove pt-BR translation and use its values simply as pt since there's no differences between these.

ThomDietrich commented 3 months ago

Hey @jfreves, not quite the whole story. Please see https://github.com/rejuvenate/lovelace-horizon-card/pull/100 CC @ViPeR5000 Pleae open a PR with your fix to all the above.

jfreves commented 3 months ago

Hey @jfreves, not quite the whole story. Please see #100 CC @ViPeR5000 Pleae open a PR with your fix to all the above.

I noticed that PR but don't understand the reason for it since the one from FragMenthor was correct.