Closed jesserockz closed 4 weeks ago
Hi, shouldn't Moonrise and Moonset be switched around as well to ensure consistency?
Hi, shouldn't Moonrise and Moonset be switched around as well to ensure consistency?
Yes, Updated =)
Hey @jesserockz, this looks great. Would you like to add anything to the README file?
Hello! This fix would be very helpful. Thanks!
Hey @jesserockz if you added a quick note the the README, I'd gladly merge your PR
Sorry @ThomDietrich I didnt really know what to add to the readme and forgot to come back to it
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
Using the
southern_flip
config flag, I swapped the sunset/sunrise, dusk/dawn and moonrise/moonset elements.Type of Change
Checklist
Please ensure that you have completed the following tasks before submitting your pull request:
dev
branch (or another appropriate branch) and verified that they are working as expected.Related Issues / Pull Requests
Please include any related issues or pull requests that this change is associated with, and use the appropriate keywords (
Closes
,Fixes
,Resolves
) to automatically close the related issues when this pull request is merged.Additional Details
Please provide any additional information that you feel is relevant to this pull request, such as screenshots, code snippets, or examples.