rejuvenate / lovelace-horizon-card

Sun Card successor: Visualize the position of the Sun over the horizon.
MIT License
476 stars 35 forks source link

Flip sunrise/sunset & dusk/dawn when southern_flip is true #144

Closed jesserockz closed 4 weeks ago

jesserockz commented 5 months ago

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

Using the southern_flip config flag, I swapped the sunset/sunrise, dusk/dawn and moonrise/moonset elements.

Type of Change

Checklist

Please ensure that you have completed the following tasks before submitting your pull request:

Related Issues / Pull Requests

Please include any related issues or pull requests that this change is associated with, and use the appropriate keywords (Closes, Fixes, Resolves) to automatically close the related issues when this pull request is merged.

Additional Details

Please provide any additional information that you feel is relevant to this pull request, such as screenshots, code snippets, or examples.

2024-08-05_07-34-39

LuNGFuLaGMaSTa commented 3 months ago

Hi, shouldn't Moonrise and Moonset be switched around as well to ensure consistency?

jesserockz commented 3 months ago

Hi, shouldn't Moonrise and Moonset be switched around as well to ensure consistency?

Yes, Updated =)

ThomDietrich commented 3 months ago

Hey @jesserockz, this looks great. Would you like to add anything to the README file?

HoracioDos commented 2 months ago

Hello! This fix would be very helpful. Thanks!

ThomDietrich commented 1 month ago

Hey @jesserockz if you added a quick note the the README, I'd gladly merge your PR

jesserockz commented 4 weeks ago

Sorry @ThomDietrich I didnt really know what to add to the readme and forgot to come back to it