search

rejuvenate / lovelace-horizon-card

Sun Card successor: Visualize the position of the Sun over the horizon.
MIT License
476 stars 35 forks source link

Update Yarn and Node #152

Closed scinos closed 3 weeks ago

scinos commented 3 weeks ago

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

This PRs updates Yarn to a non-deprecated versions, and Node to the latest LTS version. This should make development easier as we can use Yarn from Node's corepack, no need to try complex methods to install Yarn 1.x

Type of Change

ThomDietrich commented 3 weeks ago

Hey @scinos, thanks for your support! This PR to update dependencies was desperately needed :) I myself am just a repo maintainer and have no js/node experience.

If you are interested, could you also check https://github.com/rejuvenate/lovelace-horizon-card/pull/131 and see if further additions in your PR (or another) would be worthwhile?

scinos commented 3 weeks ago

This PR to update dependencies was desperately needed :)

I'm happy to update this lib and bring it to modern standards :) This PR is still in draft because I broke many tests, I'd like to fix them before merging it.

If you are interested, could you also check https://github.com/rejuvenate/lovelace-horizon-card/pull/131 and see if further additions in your PR (or another) would be worthwhile?

Sure!

scinos commented 3 weeks ago

PR ready for review (ping @ThomDietrich).

I managed to update Yarn + Node without having to change ESLint or Typescript, so this PR is now smaller than it was when I initially open it.

I can't see CI results until this PR is approved, but locally everything seems to work:

Screenshot 2024-11-05 at 10 35 03

ThomDietrich commented 3 weeks ago

Thanks! I've merged the PR to have a baseline CI response. The Build and Release job errors out with "Run actions/cache@v1: Error: Input required and not supplied: path"