Fix surplus shop inventory - Githubissues

rekterakathom / Overthrow

A dynamic and persistent revolution platform for Arma 3

https://steamcommunity.com/sharedfiles/filedetails/?id=2824471652

GNU General Public License v2.0

12 stars 9 forks source link

Fix surplus shop inventory #42

Closed Tuupertunut closed 1 year ago

Tuupertunut commented 1 year ago

This PR resolves the chaos that is loose in the inventories of surplus shops.

Bugs fixed:

Duplicate backpacks in surplus shops.
Weapon tripods were sold in surplus shops.
Backpacks with items (possibly weapons) inside were sold in surplus shops.
Sometimes the mod tried to add NVGs as backpack for criminals.

New features:

Backpacks now have sensible prices in surplus shops.
- Previously almost all of them had undefined prices (so around $25 default price).
- Now their prices are calculated based on mass, where base price = mass. This leads to quite sensible prices, for example "Assault Pack" is being sold at $40 and "Bergen Backpack" at $200.
- These prices can be overridden by setting them in prices.sqf.

New bugs:

ACE NVGs are not being sold in surplus shops. This is because the shop item discovery logic is generally broken and requires a lot of manual cranking to get any item there. This will be fixed in PR #43.