search

relab / bandwidth-incentive-simulation

MIT License
0 stars 1 forks source link

17 remove range address from config #21

Closed VHPL-UIS closed 1 year ago

VHPL-UIS commented 1 year ago

Please do not merge this one. I think this is not the best possible solution because the GetRangeAddress is called for every chunk address and node address. So, I believe the calculation should happen only once, and the function only returns it.

VHPL-UIS commented 1 year ago

And the range of address doesn't change in an experiment, so, we don't need to calculate it every time.

leandernikolaus commented 1 year ago

Maybe you can keep the field in the config, but overwrite it when initializing the config, with a function similar to the once in init_configs.

VHPL-UIS commented 1 year ago

@leandernikolaus I think this one is ready to be merged. Please have a look.

leandernikolaus commented 1 year ago

Looks good!