search

relab / bandwidth-incentive-simulation

MIT License
0 stars 2 forks source link

routing to routing package #33

Closed VHPL-UIS closed 1 year ago

VHPL-UIS commented 1 year ago

I moved routing functions to routing package. Also, removed some other functions from utils and added to packages.

leandernikolaus commented 1 year ago

Very nice, I do have a few comments: Could you also move the routing worker into the routing package?

Another question is whether it makes sense to keep forgiveness and threshold as separate packages. I currently see two options:

  1. We keep forgiveness and threshold packages and aim also to move the update functionality into these packages.
  2. We move the check forgiveness and threshold functions into the routing package since they are used as part of the routing.

Or maybe you have a different idea or good reason?

VHPL-UIS commented 1 year ago

Very nice, I do have a few comments: Could you also move the routing worker into the routing package?

Another question is whether it makes sense to keep forgiveness and threshold as separate packages. I currently see two options:

1. We keep forgiveness and threshold packages and aim also to move the update functionality into these packages.

2. We move the check forgiveness and threshold functions into the routing package since they are used as part of the routing.

Or maybe you have a different idea or good reason?

For the routing worker yes, I'll change the code and move it to the routing package. But for the two others, threshold and forgiveness, I first moved them to the routing package, then I had this doubt that should they be there? Considering their role in different experiments, I thought maybe it's better to have not them there. But if you think they should be in the routing package, I do that :)