Code cleaning.

[VHPL-UIS]

Output

• [x] remove unknown output variants from output
• [x] make sure all file creations is done via MakeFile
• [x] maybe make init, close, and log an interface, which is used from the outputWorker.
• [x] move the output worker into the output package
• [x] rename NegativeIncome in the config to something more generic since it contains many different results on the income

utils

This package contains many different things. Some ideas:

• [x] move findRoute and routing worker into a routing package
• [ ] make checkForgiveness a method on the edge
• [ ] move distance methods into the types package
• [x] move getNext either into a routing package or as a method to the node.

[leandernikolaus]

I think it would be useful to have some more concrete tasks, e.g.:

Output

• [x] remove unknown output variants from output
• [x] make sure all file creations is done via MakeFile
• [x] maybe make init, close, and log an interface, which is used from the outputWorker.
• [x] move the output worker into the output package
• [x] rename NegativeIncome in the config to something more generic since it contains many different results on the income,

  utils

  This package contains many different things. Some ideas:

• [ ] move findRoute and routing worker into a routing package
• [ ] make checkForgiveness a method on the edge
• [ ] move distance methods into the types package
• [ ] move getNext either into a routing package or as a method to the node.

[VHPL-UIS]

of course. will update it.

[leandernikolaus]

I confirmed with the students. Folder protogenerated is no longer in use and should be deleted.

[leandernikolaus]

• [x] the information printed to console at the end of main should also be reported by the output module. https://github.com/relab/bandwidth-incentive-simulation/blob/a54056dce759ce14c9dbc2668643a0b262b11c95/main.go#L130-L137

[leandernikolaus]

Did some cleaning of output in e2160e6

[leandernikolaus]

• [ ] We should update the go module name: https://github.com/relab/bandwidth-incentive-simulation/blob/a54056dce759ce14c9dbc2668643a0b262b11c95/go.mod#L1

[leandernikolaus]

I confirmed with the students. Folder protogenerated is no longer in use and should be deleted.

But there seems to be a CI pipeline that tests the proto, so we should remove that test.

[VHPL-UIS]

@leandernikolaus if we want to make checkForgiveness a method on the edge, we need to move it again to the types package or write a wrapper in the routing package on types.Edge. Which one? The second option is not very trivial, at least to me.

[VHPL-UIS]

Since we removed the checkForgiveness from the types package recently, I used option 2. Please check the PR.