relab / hotstuff

MIT License
166 stars 52 forks source link

Fix lint issues that cause GitHub actions to fail #114

Closed meling closed 4 months ago

meling commented 4 months ago

Note that this PR has disabled TestFHSBug temporarily. It should be reenabled when the problem has been identified and fixed in a separate PR.

Fixes #113

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.27%. Comparing base (9cf3d63) to head (4f9471f). Report is 2 commits behind head on master.

Files Patch % Lines
internal/orchestration/deploy.go 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== + Coverage 71.81% 72.27% +0.45% ========================================== Files 63 63 Lines 6305 6301 -4 ========================================== + Hits 4528 4554 +26 + Misses 1461 1439 -22 + Partials 316 308 -8 ``` | [Flag](https://app.codecov.io/gh/relab/hotstuff/pull/114/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=relab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/relab/hotstuff/pull/114/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=relab) | `72.27% <90.00%> (+0.45%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=relab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.