search

relab / hotstuff

MIT License
172 stars 53 forks source link

Handel #37

Closed johningve closed 2 years ago

johningve commented 2 years ago

Full implementation of Handel

Depends on #36

johningve commented 2 years ago

@Arian7394 I think it is working now, thanks to your suggestions :)

johningve commented 2 years ago

It does seem like multiple levels can be active at the same time, based on these sentences from the paper:

A node sends a message to one node from each of its active levels. Levelℓ is active if Outℓ is complete or if StartTimeℓ has elapsed.

But maybe it isn't necessary as you mentioned.

codecov-commenter commented 2 years ago

Codecov Report

Merging #37 (f038746) into master (5bac7bd) will increase coverage by 8.69%. The diff coverage is 80.13%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   52.94%   61.64%   +8.69%     
==========================================
  Files          70       73       +3     
  Lines        4444     4870     +426     
==========================================
+ Hits         2353     3002     +649     
+ Misses       1831     1566     -265     
- Partials      260      302      +42
Flag Coverage Δ
unittests 61.64% <80.13%> (+8.69%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/types.go 68.75% <43.75%> (+0.89%) :arrow_up:
crypto/ecdsa/ecdsa.go 73.11% <66.03%> (+12.34%) :arrow_up:
internal/orchestration/worker.go 67.47% <66.66%> (+0.80%) :arrow_up:
crypto/bls12/bls12.go 64.67% <67.88%> (+16.26%) :arrow_up:
crypto/crypto.go 68.65% <68.65%> (ø)
backend/config.go 79.81% <71.79%> (+18.08%) :arrow_up:
handel/session.go 83.53% <83.53%> (ø)
handel/handel.go 85.71% <85.71%> (ø)
twins/network.go 89.31% <87.50%> (+4.56%) :arrow_up:
handel/partitioner.go 92.00% <92.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bac7bd...f038746. Read the comment docs.