search

relab / hotstuff

MIT License
172 stars 53 forks source link

Update go version and dependencies #49

Closed meling closed 2 years ago

meling commented 2 years ago

The go.mod file contains the long-ago deprecated protobuf version:

github.com/golang/protobuf v1.5.2

This dependency is used in client and replica packages. The fix is trivial; the import:

"github.com/golang/protobuf/ptypes/empty"

should be replaced with:

empty "google.golang.org/protobuf/types/known/emptypb"

Currently, we are using Go 1.16. I want to convert from slice to [32]byte array without using copy; this is supported in Go 1.17.

Finally, my installed protoc-gen-gorums is newer than the one used in the existing pb.go files, preventing me from generating compatible files. Hence, I propose to upgrade both the plugin and relab/gorums to latest release version. The necessary changes should be trivial.

@Raytar @hanish520 Any reason to hold off from upgrading these dependencies?

hanish520 commented 2 years ago

@meling, updating gorums to the latest version requires code changes in the parts that handle the configuration and unicast calls. I presume these changes are small. I don't see any issues with the plugin update. I had similar issues so I updated protoc-gen-gorums plugin but set gorums dependency to 0.6