search

relab / hotstuff

MIT License
172 stars 53 forks source link

consensus: add a SubConfig method to Configuration #56

Closed johningve closed 2 years ago

johningve commented 2 years ago

This makes it possible to create subconfigurations of the main configuration.

I used this to make broadcasting optional in the synchronizer, but have since removed this code. However, I think it could be a useful feature to have anyway.

codecov-commenter commented 2 years ago

Codecov Report

Merging #56 (00c30e6) into master (3e72795) will decrease coverage by 1.53%. The diff coverage is 39.21%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   53.72%   52.18%   -1.54%     
==========================================
  Files          70       70              
  Lines        6362     6394      +32     
==========================================
- Hits         3418     3337      -81     
- Misses       2670     2774     +104     
- Partials      274      283       +9
Flag Coverage Δ
unittests 52.18% <39.21%> (-1.54%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/modules.go 93.54% <ø> (ø)
twins/network.go 81.68% <16.66%> (-4.11%) :arrow_down:
backend/config.go 48.96% <46.15%> (-15.04%) :arrow_down:
internal/proto/hotstuffpb/convert.go 76.47% <0.00%> (-16.58%) :arrow_down:
backend/server.go 40.74% <0.00%> (-5.56%) :arrow_down:
crypto/cache.go 66.40% <0.00%> (-5.47%) :arrow_down:
consensus/types.go 62.12% <0.00%> (-5.31%) :arrow_down:
synchronizer/viewduration.go 27.11% <0.00%> (-3.39%) :arrow_down:
crypto/base.go 76.08% <0.00%> (-3.27%) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e72795...00c30e6. Read the comment docs.