search

relab / hotstuff

MIT License
166 stars 52 forks source link

Removed leafBlock from synchronizer #76

Closed leandernikolaus closed 1 year ago

leandernikolaus commented 1 year ago

I wanted to study the semantics of the synchronizer, and I found that the leafBlock is always the block from the highQC. Therefore, in the current implementation, we could omit the leafBlock.

meling commented 1 year ago

I've looked at the code, and it looks fine to me. But could edit the PR description to provide some more context for this. Do you think we won't need the LeafBlock() for alternative synchronizer implementations?

meling commented 1 year ago

I don't see any issues with this PR.

@hanish520 Would this conflict with any of your other changes?

@johningve If you have a cycle to spare, please let us know your take.

I want to merge this if there are no concerns with this.