search

relab / hotstuff

MIT License
166 stars 52 forks source link

Latency #87

Closed hanish520 closed 1 year ago

hanish520 commented 1 year ago

Ability to identify the latency of the quorum certificate

codecov-commenter commented 1 year ago

Codecov Report

Merging #87 (fb10174) into master (5e26f4b) will decrease coverage by 0.07%. The diff coverage is 58.39%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   62.69%   62.63%   -0.07%     
==========================================
  Files          73       76       +3     
  Lines        7193     7414     +221     
==========================================
+ Hits         4510     4644     +134     
- Misses       2383     2474      +91     
+ Partials      300      296       -4
Flag Coverage Δ
unittests 62.63% <58.39%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/config.go 74.25% <ø> (ø)
cmd/latencygen/latency_gen.go 0.00% <0.00%> (ø)
consensus/byzantine/byzantine.go 1.75% <0.00%> (-0.04%) :arrow_down:
events.go 100.00% <ø> (ø)
genesis.go 100.00% <ø> (ø)
hotstuff.go 100.00% <ø> (ø)
leaderrotation/carousel.go 3.77% <ø> (ø)
modules/modules.go 100.00% <ø> (ø)
twins/network.go 89.25% <0.00%> (+2.74%) :arrow_up:
internal/cli/run.go 15.20% <4.76%> (-0.92%) :arrow_down:
... and 16 more

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

meling commented 1 year ago

Ping @hanish520. Could you please review my suggestions so that we can get this merged soon.

hanish520 commented 1 year ago

Ping @hanish520. Could you please review my suggestions so that we can get this merged soon.

Hein, i will look into it this weekend, we can do a live review next week when you are here.

hanish520 commented 1 year ago

@meling I reviewed the comments, and now I realized that optiblog latency recording code changes were entered into this PR. I may abandon this PR and create a new PR with changes meant for inducing latency in the framework.