search

relan / exfat

Free exFAT file system implementation
GNU General Public License v2.0
795 stars 182 forks source link

Support -a option #98

Closed scolby33 closed 6 years ago

scolby33 commented 6 years ago

Over at https://github.com/systemd/systemd/issues/9849#issuecomment-412038398, the maintainers think that an -a option is "not unreasonable to expect" from an fsck implementation; in fact their systemd-fsck implementation assumes that one is present.

When invoked with -a, other the fsck's for other filesystems "automatically repair the file system", according to the manual for e2fsck. -a has been deprecated in favor of -p, but systemd still uses the old version.

Is it possible to add an -a option for the sake of systemd compatibility?

scolby33 commented 6 years ago

fsck.cramfs has functionality to silently ignore several common fsck arguments that it doesn't need to use, including -a: http://man7.org/linux/man-pages/man8/fsck.cramfs.8.html

relan commented 6 years ago

Is it possible to add an -a option for the sake of systemd compatibility?

Sure.

In fact -a is already supported in the repair branch along with actual functionality.

scolby33 commented 6 years ago

Oh! I'm sorry I didn't see this at first--I only did a cursory look before opening the issue. Apologies for that.

What is the status of the repair branch? Is switching to that something that I should advocate to my distro (Arch, in this case), or is it not in a production-ready state? If not I can continue to judiciously ignore the error messages systemd throws at me but this time with more knowledge.

relan commented 6 years ago

The repair branch needs some more testing before I can merge it. I'd suggest to wait until a new stable version of exfat-utils is out.

relan commented 6 years ago

Done in v1.3.0.

scolby33 commented 6 years ago

Thank you!