related-sciences / nxontology-ml

Machine learning to classify ontology nodes
Apache License 2.0
6 stars 0 forks source link

Add some more few shot examples #26

Closed yonromai closed 11 months ago

yonromai commented 11 months ago

@eric-czech

I do think we can add these misclassified examples to the prompt though:

Please take a look at:

Gist: Adding the new examples surprisingly didn't improve the performance of the model.

Notes:

cc: @dhimmel @ravwojdyla

ravwojdyla commented 11 months ago

(Note: Please discard the first commit, it belongs to the already open PR https://github.com/related-sciences/nxontology-ml/pull/25 - I'll rebase once merged)

@yonromai for future reference you can change the base of a PR: image

You would change the base to the branch of the other PR, and carry on :D. GH will even rebase this PR once you merge the other one.

yonromai commented 11 months ago

(^ Rebased on main after merging #25)

eric-czech commented 11 months ago

The updated prompt with the additional examples prompts/precision_v2.txt

LGTM

Gist: Adding the new examples surprisingly didn't improve the performance of the model.

Good to know, though a big confounder with this is that comparing the GPT4 results to the manual labels directly is somewhat ill-defined. I would still expect improvements/regressions to be detectable this way if they're above a certain magnitude, so the best conclusion for my money is that the examples didn't change anything or helped to a undetectably small extent.

yonromai commented 11 months ago

Good to know, though a big confounder with this is that comparing the GPT4 results to the manual labels directly is somewhat ill-defined. I would still expect improvements/regressions to be detectable this way if they're above a certain magnitude, so the best conclusion for my money is that the examples didn't change anything or helped to a undetectably small extent.

Sounds good to me. My gut feeling tells me that it's good to keep that extra bit of supervision so I'd be in favor of merging the prompt with the added extra examples. I'll just update the older prompt to include the extra example and use that updated prompt to add the GPT tags to the catboost model (in a different PR).

eric-czech commented 11 months ago

update the older prompt to include the extra example and use that updated prompt to add the GPT tags to the catboost model (in a different PR).

Perfect 👍. That sounds right to me.