relative-ci / bundle-stats

Analyze bundle stats(bundle size, assets, modules, packages) and compare the results between different builds. Support for webpack, rspack, rollup and vite.
MIT License
570 stars 20 forks source link

Fix sort query state #4824

Closed vio closed 1 week ago

vio commented 1 week ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request involve renaming and restructuring components related to routing and state management within a React application. Key components such as AssetsContent, ModulesContent, and PackagesContent have been renamed to AssetsRoute, ModulesRoute, and PackagesRoute, respectively. Additionally, the state management logic has been updated to use a consistent naming convention for state variables, enhancing clarity. New properties, particularly setQueryState, have been introduced in various components and hooks to improve state synchronization during sorting operations, while also expanding the ComponentStateParam to include new query parameters.

Changes

File Path Change Summary
packages/ui/src/app/app.jsx Renamed components: AssetsContent β†’ AssetsRoute, ModulesContent β†’ ModulesRoute, PackagesContent β†’ PackagesRoute. Updated state variable names.
packages/ui/src/components/bundle-assets/index.jsx Added setQueryState to useRowsSort hook parameters for sorting functionality.
packages/ui/src/components/bundle-modules/index.tsx Added setQueryState to useRowsSort hook parameters; updated BundleModulesProps interface to include setState.
packages/ui/src/components/bundle-packages/index.jsx Added setQueryState to useRowsSort hook parameters; defined prop types for BundlePackages.
packages/ui/src/hooks/rows-sort.ts Updated UseRowsSortParams to include setQueryState. Redefined updateSort using useCallback for better state management.
packages/utils/src/utils/component-links.ts Expanded ComponentStateParam to include sortBy and direction properties in encode/decode functions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BundleAssets
    participant BundleModules
    participant BundlePackages
    participant RowsSort

    User->>BundleAssets: Sort rows
    BundleAssets->>RowsSort: Call useRowsSort with setQueryState
    RowsSort->>BundleAssets: Update sorting state
    BundleAssets->>User: Display sorted results

    User->>BundleModules: Sort rows
    BundleModules->>RowsSort: Call useRowsSort with setQueryState
    RowsSort->>BundleModules: Update sorting state
    BundleModules->>User: Display sorted results

    User->>BundlePackages: Sort rows
    BundlePackages->>RowsSort: Call useRowsSort with setQueryState
    RowsSort->>BundlePackages: Update sorting state
    BundlePackages->>User: Display sorted results

πŸ‡ "In the code where rabbits hop,
Renamed routes, we’ll never stop.
Sorting states with a clever twist,
Query params now can't be missed!
With every change, our code will gleam,
Hopping high, we chase the dream!" πŸ‡


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
relativeci[bot] commented 1 week ago

#11647 Bundle Size β€” 381.33KiB (+0.08%).

24ae9db(current) vs b1a4591 master#11642(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#11647
     Baseline
#11642
Regression  Initial JS 334.44KiB(+0.09%) 334.13KiB
No change  Initial CSS 46.89KiB 46.89KiB
Change  Cache Invalidation 28.59% 12.31%
No change  Chunks 3 3
No change  Assets 4 4
No change  Modules 699 699
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 39 39
No change  Duplicate Packages 1 1

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#11647](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11647-Oeo3tX1jAQakuGqzna1K?utm_source=github&utm_content=totals&utm_campaign=pr-report "View bundle analysis report") |      Baseline
[#11642](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11642-OoKi4pmZdllKJxPPlPu6?utm_source=github&utm_content=totals&utm_campaign=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11647-Oeo3tX1jAQakuGqzna1K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D&utm_source=github&utm_content=totals&utm_campaign=pr-report "View JS assets") | `334.44KiB` (`+0.09%`) | `334.13KiB` | | No change  [CSS](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11647-Oeo3tX1jAQakuGqzna1K/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D&utm_source=github&utm_content=totals&utm_campaign=pr-report "View CSS assets") | `46.89KiB` | `46.89KiB` |

Bundle analysis report Branch fix-sort-query-state Project dashboard


Generated by RelativeCI Documentation Report issue