search

relative-ci / bundle-stats

Analyze bundle stats(bundle size, assets, modules, packages) and compare the results between different builds. Support for webpack, rspack, rollup and vite.
MIT License
570 stars 20 forks source link

fix(ui): BundleModules - do not clear metric when opening side info #4827

Closed vio closed 1 week ago

vio commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the BundleModules component by updating the EntryComponentLink function to include moduleMetric in its dependency array and parameters. The props interface for BundleModules has been modified to incorporate moduleMetric and setModuleMetric, enabling the selection of different metrics. Additionally, the rendering of MetricsTable and ViewMetricsTreemap components is now conditional based on the displayType.value, improving the component's interactivity and data handling capabilities.

Changes

File Path Change Summary
packages/ui/src/components/bundle-modules/... Updated EntryComponentLink to include moduleMetric in the dependency array and parameters.
packages/ui/src/components/bundle-modules/... Modified BundleModulesProps interface to add moduleMetric and setModuleMetric properties.
packages/ui/src/components/bundle-modules/... Implemented conditional rendering for MetricsTable and ViewMetricsTreemap based on displayType.value.

Possibly related PRs

Poem

In the bundle where metrics play,
A new link shines bright today.
With sizes to choose, oh what a sight,
Metrics dance in the user’s delight.
Hopping through data, we cheer and sing,
For the joy that these changes bring! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
relativeci[bot] commented 1 week ago

#11656 Bundle Size — 381.32KiB (~+0.01%).

ae33f31(current) vs da36413 master#11654(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#11656		      Baseline
#11654
Regression  Initial JS 334.44KiB(~+0.01%) 334.43KiB
No change  Initial CSS 46.89KiB 46.89KiB
No change  Cache Invalidation 28.65% 28.65%
No change  Chunks 3 3
No change  Assets 4 4
No change  Modules 699 699
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 39 39
No change  Duplicate Packages 1 1

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#11656](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11656-acgOdlgj8LLeMC38n5Kv?utm_source=github&utm_content=totals&utm_campaign=pr-report "View bundle analysis report") |      Baseline
[#11654](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11654-JvJAVu4wbvBHcfKC6ApP?utm_source=github&utm_content=totals&utm_campaign=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11656-acgOdlgj8LLeMC38n5Kv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D&utm_source=github&utm_content=totals&utm_campaign=pr-report "View JS assets") | `334.44KiB` (`~+0.01%`) | `334.43KiB` | | No change  [CSS](https://app.relative-ci.com/projects/V1bXuieJbYttHCS75L8G/jobs/11656-acgOdlgj8LLeMC38n5Kv/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D&utm_source=github&utm_content=totals&utm_campaign=pr-report "View CSS assets") | `46.89KiB` | `46.89KiB` |

Bundle analysis report Branch fix-module-entry-link Project dashboard

Generated by RelativeCI Documentation Report issue