search

relativitydev / Gravity

ORM Framework for Relativity Custom Development
Other
16 stars 10 forks source link

fix: initialize retry service in all RsapiDao constructors #134

Closed Arithmomaniac closed 5 years ago

Arithmomaniac commented 5 years ago

Fixes an issue @aarongilbert123 noticed while writing file-driven unit tests

mrobustelli commented 5 years ago

@aarongilbert123 please make sure this fixes the issue you were looking at? I'm curious as to what the null parameter represents and why it is needed.

Arithmomaniac commented 5 years ago

I'm curious as to what the null parameter represents and why it is needed.

The null parameter is the retry service for temp file deletion (all other uses of the retry service are handled by the RSAPI provider)

aarongilbert123 commented 5 years ago

@mrobustelli Yes looks like it will fix the issue I was having.

Arithmomaniac commented 5 years ago

No, because we want to instantiate everything we would need for file operations to work properly. Just because in a test we can set it to null because we know we are not doing file operations doesn't mean we want consumers to think they can do that.

On Thu, Sep 20, 2018 at 3:22 PM Robo notifications@github.com wrote:

@mrobustelli commented on this pull request.

In Gravity/Gravity/DAL/RSAPI/RsapiDao.cs https://github.com/relativitydev/Gravity/pull/134#discussion_r219305248:

    }
  • public RsapiDao(IRsapiProvider rsapiProvider)
  • public RsapiDao(IRsapiProvider rsapiProvider, InvokeWithRetryService invokeWithRetryService)

Would it not be better to add this as an optional parameter and default it to null? public RsapiDao(IRsapiProvider rsapiProvider, InvokeWithRetryService invokeWithRetryService = null) Then we would not have to update everything else?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/relativitydev/Gravity/pull/134#pullrequestreview-157450677, or mute the thread https://github.com/notifications/unsubscribe-auth/AAn-MQBwpd2hPwq_VUsyyeEp5En32oGGks5uc_kIgaJpZM4WymPS .

--

Avi Levin

Senior Developer

w: 312.265.0136 x256

twitter: @milyli

milyli.com

http://milyli.com/[image: milyli] http://milyli.com/

Milyli - which stands for “Make It Like You Like It” - is an ediscovery software development firm dedicated to solving complex ediscovery problems with innovative, intuitive legal technology.