search

relativitydev / Gravity

ORM Framework for Relativity Custom Development
Other
16 stars 10 forks source link

Rsapi Unit tests are not properly using VerifyAll #142

Open Arithmomaniac opened 5 years ago

Arithmomaniac commented 5 years ago

Our provider tests are supposed to call mockProvider.VerifyAll after every test. But the code to do so is decorated with a SetUp attribute instead of a TearDown attribute, which never fires. Here is an example:

https://github.com/relativitydev/Gravity/blob/a4874bcd88a50f126070396d72c4dc336461c5e3/Gravity/Gravity.Test.Unit/RsapiDaoInsertTests.cs#L41-L46

Flipping this value shows that 10 tests are not written to meet the verification criterion:

image

In the process of fixing this, we should create a base unit test class to handle the mockProvider setup and verification.

Arithmomaniac commented 5 years ago

143 was not a fix; it was just a related dead-code removal.

Arithmomaniac commented 5 years ago

@aarongilbert123 Assigning it to you was a suggestion; if you don't want it, unassign yourself.