search

relativitydev / Gravity

ORM Framework for Relativity Custom Development
Other
16 stars 10 forks source link

#3 create RsapiProvider #70

Closed Arithmomaniac closed 6 years ago

Arithmomaniac commented 6 years ago

This abstracts away all of the RSAPI logic (and accompanying proxy retrying) to its own class, which handles file upload/download and RDO CRUDQ operations. This should make it much easier to unit test (see #3), as well as move towards our eventual goal of having the core Gravity interfaces (if not logic) being platform-agnostic.

The breaking change is the removal of RsapiDocumentDao. some of the refactoring became much easer when assuming that we would only ever user RdoRepository, and that class was outside of the "object CRUD" scope anyways.

Arithmomaniac commented 6 years ago

We wouldn't want to give it that name, because this only abstracts out the calls to the repository, not the mapping from RDOs to our own object types. But yes, we will want to do that in the long run, and this is a good step in that direction. And I think this has merit for unit testing independent of that.