relaton / api.relaton.org

Relaton Service API
https://relaton-api.herokuapp.com
1 stars 1 forks source link

Regenerate GitHub Action for CI with Push permission #40

Closed phuonghuynh closed 2 years ago

phuonghuynh commented 3 years ago

@ronaldtse GitHub apply new format for its tokens, so we need to update our CI Secrets token or GHA won't work as expected

We noticed your personal access token, xxxx, has an outdated format and was used to access the GitHub API xxx

ronaldtse commented 3 years ago

There is no deadline for migration so we don't need to do this now.

ronaldtse commented 3 years ago

@phuonghuynh which repo are you seeing this? I believe relaton-ci is already using the new token format.

phuonghuynh commented 3 years ago

This notice is for my PAT; not CI PAT;

Last 2 GHAs failed on emit event for deploy to lambda, https://github.com/relaton/api.relaton.org/actions/runs/1221395328, so I guess that issue related to GHA CI Token; like my tested Repo Action

ronaldtse commented 3 years ago

@phuonghuynh What is the problem here?

I have re-generated the token, but both the old and new ones already use the new format. The token has full read/write repo/packages access:

Screenshot 2021-10-26 at 12 23 22 AM
ronaldtse commented 3 years ago

The secret is called RELATON_CI_PAT in all public repositories as well as in infrastructure-lambda-api. Closing this.

phuonghuynh commented 3 years ago

@andrew2net could we test new CI token ?

andrew2net commented 3 years ago

@phuonghuynh I've tried to run the manual-release workflow twice with API_VERSION: 1.9.1-preview.1 and API_VERSION: 1.9.1-preview.2, GEM_VERSION: 1.9.1 but the on-release workflow isn't triggered.

ronaldtse commented 2 years ago

@phuonghuynh could you please help with this task? Thanks.

phuonghuynh commented 2 years ago

Yes

phuonghuynh commented 2 years ago

@andrew2net could you help to fix GHA build failed because of rspec error?

https://github.com/relaton/api.relaton.org/runs/7592911061?check_suite_focus=true

andrew2net commented 2 years ago

@phuonghuynh fixed

ronaldtse commented 2 years ago

Ping @phuonghuynh

phuonghuynh commented 2 years ago

New GHA working, so I think we can close this issue, https://github.com/relaton/api.relaton.org/actions/runs/2869996420

ronaldtse commented 2 years ago

Thanks @phuonghuynh !