search

relaton / relaton-bib

MIT License
3 stars 1 forks source link

Update grammar to deal with region #55

Closed opoudjis closed 2 years ago

opoudjis commented 2 years ago

I've finally updated the grammar to address https://github.com/relaton/relaton-bib/issues/37

You probably don't need to do a thing, because you'd already implemented it, but just in case, could you please make sure that Relaton aligns with the updated grammar?

andrew2net commented 2 years ago

@opoudjis Jing returns errors with the new grammar:

[{:column=>23,
  :line=>868,
  :message=>"multiple definitions of \"city\" without \"combine\" attribute",
  :source=>"/Users/andrej/RubyProjects/relaton-bib/grammars/biblio.rng"},
 {:column=>26,
  :line=>878,
  :message=>
   "multiple definitions of \"country\" without \"combine\" attribute",
  :source=>"/Users/andrej/RubyProjects/relaton-bib/grammars/biblio.rng"}]
opoudjis commented 2 years ago

Ah, ok, I see why. Fixing.

andrew2net commented 2 years ago

@opoudjis I see you renamed the second city definition. The two city definitions were identical. I think it's possible just remove one of them. The multiple definitions of country remain and they are different: element country { text } and element country { RegionType }. Could you resolve the issue?