search

relaton / relaton-bib

MIT License
3 stars 1 forks source link

Bump nokogiri version to "~> 1.16" #91

Closed maxirmx closed 5 months ago

maxirmx commented 5 months ago

In order to package metanorma on MSys it has to be compatible with gcc 14 which in turn requires nokogiri 1.16

maxirmx commented 5 months ago

@ronaldtse @CAMOBAP Please help

ronaldtse commented 5 months ago

@maxirmx added you to the team. Thanks!

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.93%. Comparing base (afc3ac0) to head (6ea74e8). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ======================================= Coverage 99.93% 99.93% ======================================= Files 48 48 Lines 3018 3032 +14 ======================================= + Hits 3016 3030 +14 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ronaldtse commented 5 months ago

@maxirmx @andrew2net I believe we can merge once tests pass, and release.

maxirmx commented 5 months ago

It attempts to use setup-ruby action to install version 3.4 and support for 3.4 it is not released in this action Not sure what to do ... Ignoring this issue may be a good choice

andrew2net commented 5 months ago

@ronaldtse I'm unable to merge branches from forked repos. I'll just update the Nokogiri dependency version and release this gem.

CAMOBAP commented 5 months ago

@maxirmx ruby 3.4 is marked as experimental. so it should not fail the ci.

There was an issue with tests-passed job which is resolved so if you rebate/merge main workflow should be "green"

maxirmx commented 5 months ago

@CAMOBAP Could you please advise, shall it be released to go to metanorma build ? Thank you

CAMOBAP commented 5 months ago

@maxirmx hard to say because I don't see the whole picture, better ask @andrew2net and @opoudjis

ronaldtse commented 5 months ago

@ronaldtse I'm unable to merge branches from forked repos. I'll just update the Nokogiri dependency version and release this gem.

How come? We don't have extra permissions to set anywhere...

andrew2net commented 5 months ago

@ronaldtse I don't see the "merge" button, and can only close the PR or comment. Have no idea why.

opoudjis commented 5 months ago

@CAMOBAP Could you please advise, shall it be released to go to metanorma build ? Thank you

Nokogiri 1.16. @maxirmx, or Ruby 3.4? Definitely not 3.4 yet, there's going to be any number of gems we now need to make explicit dependencies and haven't yet; I've only just upgraded locally to 3.3. Maybe next release, likelier release after next.

I inherit my nokogiri version dependency from relaton-bib, and I've been using Nokogiri 1.16 without realising it was upgraded for a few days now. I think it's fine.

maxirmx commented 5 months ago

@CAMOBAP Could you please advise, shall it be released to go to metanorma build ? Thank you

Nokogiri 1.16. @maxirmx, or Ruby 3.4? Definitely not 3.4 yet, there's going to be any number of gems we now need to make explicit dependencies and haven't yet; I've only just upgraded locally to 3.3. Maybe next release, likelier release after next.

I inherit my nokogiri version dependency from relaton-bib, and I've been using Nokogiri 1.16 without realising it was upgraded for a few days now. I think it's fine.

Nokogiri 1.16, thank you