Closed ronaldtse closed 2 years ago
- https://github.com/relaton/relaton-data-bipm/blob/master/data/cgpm/resolution/21.yaml (This is actually 1999-21)
- https://github.com/relaton/relaton-data-bipm/blob/master/data/cgpm/resolution/3.yaml (This is actually the 1901 meeting, but there are resolution 1 and resolution 2.)
@ronaldtse
FYI:
the cgpm/resolution/21.yaml
now is cgpm/meetings/21.yaml
the cgpm/resolution/3.yaml
now is cgpm/meetings/3.yaml
I didn't get why 21.yaml
should be named using pattern yyyy-ii
but 3.yaml
using pattern yyyy
?
References for these documents are CGPM Meetings 21
and CGPM Meetings 3
. Should the references be CGPM Meetings 1999-21
and CGPM Meetings 1901
?
- FYI: the
cgpm/resolution/21.yaml
now is cgpm/meetings/21.yaml thecgpm/resolution/3.yaml
now is cgpm/meetings/3.yaml
Maybe there is a misunderstanding -- we have two classes here, "Meeting" and "Resolution".
The files I meant were:
- I didn't get why
21.yaml
should be named using patternyyyy-ii
but3.yaml
using patternyyyy
?
For Resolutions, we name them "yyyy-ii.yaml". I think this is correct because it allows us to identify the year and the ID of the resolution.
For Meetings, we name them "yyyy.yaml" (yyyy is year of meeting) or just "xx.yaml" (xx is number of meeting)? I'm not sure which one is better.
- References for these documents are
CGPM Meetings 21
andCGPM Meetings 3
. Should the references beCGPM Meetings 1999-21
andCGPM Meetings 1901
?
We have two kinds of objects here: Meeting and Resolution.
Meetings:
Resolutions (syntax 1):
Resolutions (syntax 2):
Resolutions (syntax 2):
- "CGPM Resolution 21-01" (resolution 1 of meeting in 1999 which is Meeting 21)
- "CGPM Resolution 3-01" (resolution 1 of meeting in 1903 which is Meeting 3)
@ronaldtse do we really need the syntax 2? We have to create duplicated files with names matched to the syntax or create mapping file.
Why not use an index? We should really not tie the file name pattern with the software.
@ronaldtse using index slows down fetching documents because it needs two HTTP request for each document. Maybe we need to consider caching indexes. I suggest to use singleton to keep index in memory. What do you think?
@andrew2net I think having index on disk (cached) is a reasonable compromise.
@ronaldtse in case the relaton is run in AWS Lambda it's impossible to use container's file system to save index. Should we use S3 in the case?
@andrew2net Ah I was thinking about local. Now the challenge about 2 requests using the index makes more sense. I thought Lambda would still support caching, but I guess it would go away at the next run.
For Relaton API, maybe we should have an S3 that mirrors all the Git repos offline...?
@ronaldtse we can detect if a gem is run in Lambda then use S3 else use local fs.
Resolutions (syntax 2):
- "CGPM Resolution 21-01" (resolution 1 of meeting in 1999 which is Meeting 21)
- "CGPM Resolution 3-01" (resolution 1 of meeting in 1903 which is Meeting 3)
@ronaldtse some meetings have parts. For example CIPM Meeting 101-1
. Should the syntax 2 looks like CIPM Decision 101-1-01
or just CIPM Decision 101-01
? The parts have end-to-end numbering, so the second version will produce unique references.
Good find. I think the resolutions should be cited as "CIPM Meeting 101-01". The sub-meetings should not be used in resolutions/decision/etc numbering.
Can you help document these decisions in the README? Thanks.
@ronaldtse I think we need to add to the index the documents from the bipm-si-brochure
dataset.
site/documents
folder?*.presentation.xml
files in the site/documents
folder?site/documents/sib-a4-en.xml
have a document identifier BIPM
. Shouldn't it be something like BIPM SIB-A4
?@andrew2net yes indeed. We need to add the index from those documents. But let's do that in a new issue?
- Do we need to convert all the documents from the dataset's
site/documents
folder?
Yes.
- Some of the documents have English and French files. Do we need to compose them into one Relaton item?
Yes.
- What are the
*.presentation.xml
files in thesite/documents
folder?
Those documents are the Metanorma Presentation XML files. But those are not supposed to be in Git main
? They are only supposed to be in gh-pages
branch.
- The
site/documents/sib-a4-en.xml
have a document identifierBIPM
. Shouldn't it be something likeBIPM SIB-A4
?
I will have to check and get back to you...
In relaton-data-bipm/data/cgpm/resolution , some files are not named correctly to the pattern
yyyy-ii
where yyyy is year and ii is the identifier.e.g.
As we can see from the second issue, this is purely a data parsing issue in Relaton-BIPM.
@andrew2net can you please help fix this ASAP? Thanks.