relaton / relaton-bipm

MIT License
2 stars 0 forks source link

(URGENT) Failure to cite the SI Brochure #30

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago

The example shown in the README does not work:

$ bundle exec relaton fetch "BIPM SI Brochure"
[relaton-bipm] ("BIPM SI Brochure") fetching...
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM si-brochure"
[relaton] (BIPM si-brochure) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM SI-brochure"
[relaton] (BIPM SI-brochure) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM SI-Brochure"
[relaton] (BIPM SI-Brochure) not found.
No matching bibliographic entry found
ronaldtse commented 1 year ago

But using "BIPM Brochure" works:

$ bundle exec relaton fetch "BIPM Brochure"
[relaton-bipm] ("BIPM Brochure") fetching...
[relaton-bipm] ("BIPM Brochure") found BIPM Brochure
<bibdata type="standard">
  <fetched>2022-08-29</fetched>
  <title format="text/plain" language="en">The International System of Units</title>
  <title format="text/plain" language="en">Historical notes on the development of the International System of Units and its base units</title>
  <title format="text/plain" language="fr">Le système international d’unités</title>
  <title format="text/plain" language="fr">Notes historiques sur l’évolution du Système international d’unités et ses unités de base</title>

This is because someone changed the identifier of the si-brochure.yaml file at this commit: https://github.com/relaton/relaton-data-bipm/commit/719caed033610300f934d658d916c5eac9441a53#diff-1278c95b2e7e1cacd4f54dd99126cff0ede88521c1942dc8e370be9ea4ffdbcf

The document ID should be "SI Brochure", not "si-brochure" or "Brochure".

andrew2net commented 1 year ago

This is because someone changed the identifier of the si-brochure.yaml file at this commit: relaton/relaton-data-bipm@719caed#diff-1278c95b2e7e1cacd4f54dd99126cff0ede88521c1942dc8e370be9ea4ffdbcf

@ronaldtse the identifier comes from the metanorma/bipm-si-brochure repo.

I just realised that the https://github.com/metanorma/bipm-si-brochure generates 2 files with same ID:

It seems the second is just a variant of "SI Brochure". Should the skip the second one?

ronaldtse commented 1 year ago

They are different.

Can you help encode the second one correctly?