relaton / relaton-bipm

MIT License
2 stars 0 forks source link

Missing Metrologia final page numbers #42

Closed opoudjis closed 1 year ago

opoudjis commented 1 year ago

This appears to be a data quality issue.

Metrologia articles are now being cited only with their initial page, not with the range of pages they have. (I cannot believe that Metrologia only publishes one-page–long articles.)

So

bundle exec relaton fetch "BIPM Metrologia 34 3 261"

returns

  <extent>
    <locality type="page">
      <referenceFrom>261</referenceFrom>
    </locality>
  </extent>

In https://github.com/metanorma/metanorma-iso/issues/775, it was rendering with pp 261-290.

The problem is that the Bibtex reference and online rendering at https://iopscience.iop.org/article/10.1088/0026-1394/34/3/9/meta

Also give only the starting page.

That's bad quality data, but I believe we should be correcting it. How did we establish the end of the page number range before?

ronaldtse commented 1 year ago

This issue needs to be fixed with https://github.com/relaton/relaton-bipm/issues/28

ronaldtse commented 1 year ago

For this particular entry you cited:

It does provide the page numbers.

      <fpage>261</fpage>
      <lpage>290</lpage>

However, not all Metrologia entries provide page numbers:

This one has no page (first or last) number.

andrew2net commented 1 year ago

However, not all Metrologia entries provide page numbers:

This one has no page (first or last) number.

@ronaldtse what does the <page-count count="9"/> element mean? Does it happen to mean pages from 1 to 9?

ronaldtse commented 1 year ago

Maybe, it might mean it is a book of 9 pages, so 1-9. Let’s just assume that for now. Can you find this item online?

andrew2net commented 1 year ago

@ronaldtse found it here but don't see any pages.

ronaldtse commented 1 year ago

@andrew2net in that link the original PDF looks like this:

Screenshot 2023-02-11 at 8 55 10 AM

There is really no page number. It seems that in this Metrologia number they really do not use page numbers anymore. Each article is individually marked with a number like 045001, 045002...

Screenshot 2023-02-11 at 8 56 33 AM

So let's not insist on a page number, but use the article identifying number.

andrew2net commented 1 year ago

@opoudjis fixed in relaton-bipm v1.14.2, but it's discovered that IDs with a page number at the end are not unique, and some documents don't have a page number at all. BIPM uses article numbers so we switched to using them too. May be should find another way to avoid duplication of IDs because some article numbers look weird. For example ac1e04. So the "BIPM Metrologia 34 3 261" should be fetched with BIPM Metrologia 34 3 9" reference now.

opoudjis commented 1 year ago

Big change, and need to alert editors about this....

@anermina @manuelfuenmayor

ronaldtse commented 1 year ago

We actually need to separate the identification of "article number" and "first page" in the syntax. 3 consecutive numbers after "Metrologia" does not make sense.

andrew2net commented 1 year ago

fixed https://github.com/relaton/relaton-data-bipm/blob/436f9a9db429cfdb43975a580ed1c0990653d9d9/data/metrologia-34-3-9.yaml#L78-L79