relaton / relaton-bipm

MIT License
2 stars 0 forks source link

Failure to fetch CGPM Resolution data that exists #44

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago

The data exists right here:

But I cannot fetch it:

$ bundle exec relaton fetch "CGPM -- Resolution 6 (1979)"
[relaton] (CGPM -- Resolution 6 (1979)) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CGPM -- Resolution 6 (1979)"
[relaton] (BIPM CGPM -- Resolution 6 (1979)) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CGPM Resolution 6 (1979)"
[relaton-bipm] ("BIPM CGPM Resolution 6 (1979)") fetching...
[relaton-bipm] ("BIPM CGPM Resolution 6 (1979)") not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CGPM-Resolution-1979-06"
[relaton-bipm] ("BIPM CGPM-Resolution-1979-06") fetching...
[relaton-bipm] ("BIPM CGPM-Resolution-1979-06") not found.
No matching bibliographic entry found
ronaldtse commented 1 year ago

This one as well:

$ bundle exec relaton fetch "BIPM CIPM Resolution (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CIPM -- Resolution (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CIPM -- Resolution 0 (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found
andrew2net commented 1 year ago

$ bundle exec relaton fetch "CGPM -- Resolution 6 (1979)"
[relaton] (CGPM -- Resolution 6 (1979)) not found.
No matching bibliographic entry found
$ bundle exec relaton fetch "BIPM CGPM -- Resolution 6 (1979)"
[relaton] (BIPM CGPM -- Resolution 6 (1979)) not found.
No matching bibliographic entry found

If we get a log message from [relatotn], we get a result from the cache. I'm able to fetch these documents using relaton-bipm v1.14.2. Please try to clean the relaton cache relaton db clear.


$ bundle exec relaton fetch "BIPM CGPM Resolution 6 (1979)"
[relaton-bipm] ("BIPM CGPM Resolution 6 (1979)") fetching...
[relaton-bipm] ("BIPM CGPM Resolution 6 (1979)") not found.
No matching bibliographic entry found

I can fetch the document. What relaton-bipm version do you use?


$ bundle exec relaton fetch "BIPM CGPM-Resolution-1979-06"
[relaton-bipm] ("BIPM CGPM-Resolution-1979-06") fetching...
[relaton-bipm] ("BIPM CGPM-Resolution-1979-06") not found.
No matching bibliographic entry found

For the document relaton-bipm accepts following references:

andrew2net commented 1 year ago

$ bundle exec relaton fetch "BIPM CIPM Resolution (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found

This is not correct reference. Should be "BIPM CIPM -- Resolution (1879)".


$ bundle exec relaton fetch "BIPM CIPM -- Resolution (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found

This is correct and it works for me.

$ bundle exec relaton fetch "BIPM CIPM -- Resolution 0 (1879)"
[relaton] (BIPM CIPM Resolution (1879)) not found.
No matching bibliographic entry found

Acceptable references for this document are:

ronaldtse commented 1 year ago

@andrew2net ok after I did relaton db clear, this worked:

bundle exec relaton fetch "BIPM CIPM -- Resolution (1879)"

It seems that the db cache mechanism needs some updating. We can't rely on users / metanorma clearing the relaton db to work.

Also, the syntax requiring -- is not ideal. We ought to support: CIPM {TYPE} ({YEAR}) as well.

Moreover, this requirement on only using the new format does not make sense. Look at what we have in the bipm-si-brochure: https://github.com/metanorma/bipm-si-brochure/blob/main/sources/sections-en/99-bibliography.adoc

Are you saying the recent changes to relaton-bipm broke all those references? That's a problem.

opoudjis commented 1 year ago

No. I updated to this new reference, when the existing reference in the standoc rspec failed to work.

And it works locally, and it does not work on Github Actions:

https://github.com/metanorma/metanorma-standoc/actions/runs/4268439835/jobs/7430938305

This is broken. I don't know how, but this is broken.

opoudjis commented 1 year ago

Ignore my comments, is now working for me.

andrew2net commented 1 year ago

Also, the syntax requiring -- is not ideal. We ought to support: CIPM {TYPE} ({YEAR}) as well.

@ronaldtse we can add this format.

Are you saying the recent changes to relaton-bipm broke all those references? That's a problem.

Earlier we decided to no support the old format, but if we still need it we can add such references. The relaton-data-bipm has index with multiple references.

andrew2net commented 1 year ago

fixed in v 1.14.3 https://github.com/relaton/relaton-bipm#basic-pattern

relaton fetch "BIPM CIPM Resolution (1879)"
[relaton-bipm] ("BIPM CIPM Resolution (1879)") fetching...
[relaton-bipm] ("BIPM CIPM Resolution (1879)") found CIPM -- Resolution (1879)
<bibdata type="proceedings" schema-version="v1.2.1">
...