search

relaton / relaton-bipm

MIT License
2 stars 0 forks source link

(URGENT) Conflict in document type with Metanorma (`brochure`) #47

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago 
[relaton-bib] WARNING: type "brochure" is invalid.
...
Document Attributes: standard is not a legal document type: reverting to 'brochure'

The brochure document type is a valid type in BIPM.

Issue discovered in:

andrew2net commented 1 year ago

@ronaldtse we have type and doctype attributes. The type is defined in the grammar and can't be brochure. The BIPM doctype is defined in the flavor gramma and brochure is allowed value for it. The log message said that the type attribute has brochure value which is invalid.

ronaldtse commented 1 year ago

@andrew2net does this mean it is an issue with Metanorma? Ping @opoudjis .

andrew2net commented 1 year ago

@ronaldtse If the incorrect type comes from Metanorma then it does.

ronaldtse commented 1 year ago

Thank you @andrew2net ! Will wait for @opoudjis to review.

opoudjis commented 1 year ago

This is specific to the compilation of collections.

The collection YAML specifies brochure as the doctype, which is indeed wrong, this is a standard. Brochure is the ext/doctype.

opoudjis commented 1 year ago

Suppress error report on default doctype, if no doctype has been supplied at all.