search

relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Issues with pubid-iso 0.1.12 #133

Closed ronaldtse closed 1 year ago

ronaldtse commented 1 year ago

From @andrew2net https://github.com/metanorma/pubid-iso/issues/117

The relaton-iso has issues with the latest pubid-iso v0.1.12 https://github.com/relaton/relaton-iso/actions/runs/3122107588/jobs/5063838020#step:6:302

Two tests fail because identical amendments comparation is false in https://github.com/relaton/relaton-iso/blob/73e86fe8e156b26fd9dac59a21ae37971ca17c31/lib/relaton_iso/iso_bibliography.rb#L245

One test fails because the pubid-iso raises the Pubid::Iso::Errors::SupplementWithoutYearError

ronaldtse commented 1 year ago

The behavior of Pubid::Iso::Errors::SupplementWithoutYearError is correct because a Supplement (Amd/Cor) cannot have a base document PubID without year/edition.

We will need to update the exceptions.

ronaldtse commented 1 year ago

This task is being dealt with at https://github.com/relaton/relaton-iso/pull/132

andrew2net commented 1 year ago

@mico thank you