relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Cannot fetch ISO/IEC 10646 #142

Closed anermina closed 1 year ago

anermina commented 1 year ago

ISO/IEC 10646 cannot be auto-fetched.

bundle exec relaton fetch "ISO/IEC 10646"
(...)
C:/tools/ruby27/lib/ruby/gems/2.7.0/gems/pubid-iso-0.3.1/lib/pubid/iso/type.rb:53:in `initialize': ISP type is not available (Pubid::Iso::Errors::WrongTypeError)
ronaldtse commented 1 year ago

"ISO/IEC 10646" is correct -- the problem seems to lie with pubid-iso failing with an "ISP" search result:

However, in the search results on iso.org, I don't see any "ISP" document, until the 5th page:

Screen Shot 2022-12-08 at 8 21 57 AM

...

Screen Shot 2022-12-08 at 8 22 40 AM

This requires implementation of https://github.com/metanorma/pubid-iso/issues/165

andrew2net commented 1 year ago

@ronaldtse the relaton-iso gets the first 100 hits from a search result and then parses all the IDs to find a hit that matches the reference. So one of the hits has an ID that the pubid-iso fails to parse:

Pubid::Iso::Identifier.parse_from_title("ISO/IEC ISP 11186-2:1996 Information technology — International Standardized Profiles FVT3nn — Virtual Terminal Basic Class — Register of attribute assignment type definitions — Part 2: FVT311 — Repertoire Assignment Type for ISO/IEC 10646")
=> ISP type is not available
ronaldtse commented 1 year ago

@andrew2net in this case can Relaton not crash if there is an unparseable entry at the pubid level? Thanks.

andrew2net commented 1 year ago

fixed in v 1.14.2