relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Relaton-ISO creates cache for unclean references #58

Closed ronaldtse closed 5 years ago

ronaldtse commented 5 years ago

In geolexica.org , both of these files are created in the cache:

Both files have the same content. Obviously when Relaton creates the cache file, it must be using the normalized document identifier, not what was directly given. e.g. given "ISO 12620:1999 - blah", the normalized filename should still be iso_12620_1999.xml.

There are 7 of these in geolexica.org:

ronaldtse commented 5 years ago

This also applies to ITU, geolexica.com has:

andrew2net commented 5 years ago

@ronaldtse I'll fix the issue with the underscores. Concerning using a document identifier. We can't use a document identifier as a filename. The problem is we don't have a document identifier when fetching a document. We have a reference only. Before we retrieve the document from the internet we should check if there is a file with a name matched to the reference. One document could be fetched by many different references. For example "ISO 123 2014" returns a document and we save it to iso_123_2014. If we search by "ISO 124" reference we will get the same document if it is the lastest with the number. But we don't know it before we fetch the document. There are other cases like all parts, attempts ISO/IEC and stages, when one document could be fetched by different references. If we save these documents using their document identifiers, how do we find the files by references?

andrew2net commented 5 years ago

This issue is related to relaton gem. Move it there.

ronaldtse commented 5 years ago

This is now superseded by https://github.com/metanorma/relaton/issues/53