relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

URGENT: Fetching of ISO 19136 crash #71

Closed ronaldtse closed 5 years ago

ronaldtse commented 5 years ago

@andrew2net please help fix this:

https://github.com/metanorma/mn-itu-docs/pull/5

Error trace:

fetching ISO 19136...
1702#<Thread:0x0000000003706298@/home/travis/build/metanorma/mn-itu-docs/vendor/bundle/ruby/2.5.0/gems/relaton-bib-0.2.4/lib/relaton_bib/workers_pool.rb:17 run> terminated with exception (report_on_exception is true):
1703/home/travis/build/metanorma/mn-itu-docs/vendor/bundle/ruby/2.5.0/gems/relaton-iso-0.5.2/lib/relaton_iso/scrapper.rb:309:in `fetch_title': undefined method `text' for nil:NilClass (NoMethodError)
1704    from /home/travis/build/metanorma/mn-itu-docs/vendor/bundle/ruby/2.5.0/gems/relaton-iso-0.5.2/lib/relaton_iso/scrapper.rb:141:in `block in fetch_titles_abstract'
1705    from /home/travis/build/metanorma/mn-itu-docs/vendor/bundle/ruby/2.5.0/gems/relaton-iso-0.5.2/lib/relaton_iso/scrapper.rb:134:in `each'
1706

Originally posted by @ronaldtse in https://github.com/metanorma/mn-itu-docs/pull/5#issuecomment-529301606

andrew2net commented 5 years ago

@ronaldtse this issue fixed in v0.5.4. Could you use the last version?

ronaldtse commented 5 years ago

@andrew2net that’s great, thanks. Could you make a PR at the problematic repo to fix this? Thanks!

ronaldtse commented 5 years ago

@andrew2net confirmed fixed. Thanks!