search

relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Additional "comma" after reference name crashes relaton #88

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

Error in build: https://gitlab.com/metanorma/iso-10303/-/jobs/543046344

* [[[iso10303-45,ISO 10303-45:1998,]]], _Industrial automation systems and integration -- Product data representation and exchange -- Part 45: Integrated generic resource: Materials_.
[relaton-iso] ("ISO 10303-45:1998,") fetching...
9750
[relaton-iso] ("ISO 10303-45:1998,") found ISO 10303-45:1998
9751
bundler: failed to load command: metanorma (/usr/local/bundle/bin/metanorma)
9752
RuntimeError: error parsing fragment (1)
9753
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/node.rb:476:in `in_context'
9754
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/node.rb:476:in `parse'
9755
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document_fragment.rb:19:in `initialize'
9756
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document.rb:235:in `new'
9757
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document.rb:235:in `fragment'
9758
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:354:in `<<'
9759
  /usr/local/bundle/gems/metanorma-standoc-1.3.26/lib/asciidoctor/standoc/section.rb:135:in `block in annex_parse'
9760
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:394:in `insert'
9761
  /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:377:in `method_missing'
9762
  /usr/local/bundle/gems/metanorma-standoc-1.3.26/lib/asciidoctor/standoc/section.rb:133:in `annex_parse'
9763
ronaldtse commented 4 years ago

But same issue after fixing comma:

4209 [relaton-iso] ("ISO 10303-45") fetching...
4210 [relaton-iso] ("ISO 10303-45") found ISO 10303-45:1998
4211 bundler: failed to load command: metanorma (/usr/local/bundle/bin/metanorma)
4212 RuntimeError: error parsing fragment (1)
4213   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/node.rb:476:in `in_context'
4214   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/node.rb:476:in `parse'
4215   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document_fragment.rb:19:in `initialize'
4216   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document.rb:235:in `new'
4217   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/document.rb:235:in `fragment'
4218   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:354:in `<<'
4219   /usr/local/bundle/gems/metanorma-standoc-1.3.26/lib/asciidoctor/standoc/section.rb:135:in `block in annex_parse'
4220   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:394:in `insert'
4221   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:377:in `method_missing'
4222   /usr/local/bundle/gems/metanorma-standoc-1.3.26/lib/asciidoctor/standoc/section.rb:133:in `annex_parse'
4223   /usr/local/bundle/gems/metanorma-iso-1.3.23/lib/asciidoctor/iso/section.rb:31:in `block in section'
4224   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:295:in `initialize'
4225   /usr/local/bundle/gems/nokogiri-1.10.9/lib/nokogiri/xml/builder.rb:254:in `new'
andrew2net commented 4 years ago

@ronaldtse it seems an issue with metanorma. relaton doesn't return any errors.

relaton fetch -t ISO 'ISO 10303-45:1998,'
[relaton-iso] ("ISO 10303-45:1998,") fetching...
[relaton-iso] ("ISO 10303-45:1998,") found ISO 10303-45:1998
...
ronaldtse commented 4 years ago

Thanks @andrew2net for checking! I don't actually have this issue on my local, only in the metanorma/mn container...

ping @CAMOBAP to see if you have a clue?