relaton / relaton-iso

RelatonIso: ISO Standards metadata using the BibliographicItem model
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Problem in fetching Amendment document #93

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

From https://github.com/metanorma/mn-samples-iho/pull/55/checks?check_run_id=835861267

The document identifier seems correct but it’s parsing it as something else?

[relaton-iso] ("ISO 19131:2007/Amd 1") fetching...
301
[relaton-iso] WARNING: no match found online for ISO 19131:2007:2011. The code must be exactly like it is on the standards website.
302
[relaton-iso] (There was no match for 2011, though there were matches found for 2007.)
ronaldtse commented 4 years ago

@andrew2net problem still occurring:

2020-08-06T21:39:04.3371281Z [relaton-iso] ("ISO 19131:2007/Amd 1") fetching...
2020-08-06T21:39:04.7388497Z [relaton-iso] WARNING: no match found online for ISO 19131:2007:2011. The code must be exactly like it is on the standards website.
2020-08-06T21:39:04.7389302Z [relaton-iso] (There was no match for 2011, though there were matches found for 2007.)
2020-08-06T21:39:04.7389695Z [relaton-iso] If you wanted to cite all document parts for the reference, use "ISO 19131:2007 (all parts)".
2020-08-06T21:39:04.7390039Z If the document is not a standard, use its document type abbreviation (TS, TR, PAS, Guide).

https://github.com/metanorma/mn-samples-iho/runs/955706259?check_suite_focus=true

andrew2net commented 4 years ago

@ronaldtse the relaton-iso fetches the "ISO 19131:2007/Amd 1" reference without problem when standing alone but in the mn-samples-iho it's unable to fetch the reference. I'll debug the mn-samples-iho.

andrew2net commented 4 years ago

@ronaldtse the metanoram extracts the last year in the reference ISO 19131:2007/Amd 1:2011 as year of a document. The relaton extracts the first year. So these years don't match. Should we update relaton to use the last year or metanoram to use the first year?

ronaldtse commented 4 years ago

ISO 19131:2007/Amd 1:2011 => Amd 1:2011 of ISO 19131:2007 (base document).

The parsing should be ((ISO 19131:2007)/Amd 1):2011.

Year of publication of this document is 2011, the document name is ISO 19131:2007/Amd 1.

andrew2net commented 4 years ago

Fixed. Please update relaton-iso to version 1.2.1