search

relaton / relaton-itu

Relaton-ITU: retrieve ITU Standards for bibliographic use using the Relaton BibliographicItem model
https://www.relaton.org
MIT License
2 stars 1 forks source link

Enable VCR debug logs #6

Closed CAMOBAP closed 5 years ago

CAMOBAP commented 5 years ago
CAMOBAP commented 5 years ago

Issue reproduces on randomly on travis, appveyor & sometimes locally, if you have some guess please let me know

CAMOBAP commented 5 years ago

I have reproduced issue locally with while bundle exec rake; do :; done command

Investigation continued

CAMOBAP commented 5 years ago

Highly likely it's race condition somewhere https://github.com/vcr/vcr/issues/200 - marked as fixed but I will check history

CAMOBAP commented 5 years ago

I have faced with same issue on https://github.com/metanorma/metanorma-standoc/ repository

CAMOBAP commented 5 years ago

Ready for review

ronaldtse commented 5 years ago

@camobap795 I see that the Gemfile now points to a particular commit of the vcr gem — just wanted to let you know that this doesn’t propagate to the gemspec and gems that depend on this gem. I.e. the downstream gems that fail due to this gem won’t be fixed.

Did you really want to merge this? (We should merge Ruby 2.5 for sure)

CAMOBAP commented 5 years ago

@ronaldtse I think this is not the case, we do similar fix for https://github.com/metanorma/metanorma-gb/commit/2e5b3ebccc3799f5ebb01cb0c6622129ac1559cf

I just fixated commit because I 100% sure that there is no issues with this repo at this point

But let's wait for @opoudjis and @andrew2net to check too

ronaldtse commented 5 years ago

OK merging this now, will open new issue to remove fixation of VCR gem.