relaton / support

Internal repository support for Relaton
0 stars 0 forks source link

URGENT Some relaton-data-* repos should keep data folder #11

Closed andrew2net closed 1 year ago

andrew2net commented 1 year ago

Most of relaton-data- repos regenerate all files in data dir every time they run, but some repos update only the last changes or don't generate any files at all. For example, relaton-data-iec is scheduled to fetch only the last updates, we need to keep previously fetched in this case. A full update can be run manually and all the files in the data dir should be removed in this case. The relaton-data-iho doesn't generate any files in the data folder at all https://github.com/relaton/relaton-data-iho/issues/22 We need to check all other relaton-data- repos if they need to keep the data folder.

This issue causes issues: https://github.com/relaton/relaton-iec/issues/51 and https://github.com/relaton/relaton-iec/issues/52

CAMOBAP commented 1 year ago

crawler updated, I will double check repos

@andrew2net should I revert last commits for relaton-data-iec or relaton-data-iho ?

CAMOBAP commented 1 year ago

@andrew2net I need your help, to confirm that data directoy should not be removed for:

Should not delete data (confirmed by @andrew2net previously):

The crawler.rb removes data in repos below (and it looks right):

Empty or manually updated repos:

Outdated crawler.rb (@CAMOBAP to prepare relevant PRs):

andrew2net commented 1 year ago

crawler updated, I will double check repos

@andrew2net should I revert last commits for relaton-data-iec or relaton-data-iho ?

@CAMOBAP I've regenerated data in the relaton-data-iec and disabled the schedule temporarily, don't touch it. The relaton-data-iho needs to be reverted.

andrew2net commented 1 year ago

We shouldn't remove the data directory for the following data repositories:

We don't use the relaton-data-ietf anymore so its schedule should be disabled.

The relaton-data-iso and relaton-data-xsf are not in use yet. The relaton-model-jis is not a dataset. It's a JIS data model. We shouldn't do anything with the repo in this context.

I'm curious, why do we need to move the data-removing command from repos to the support?

CAMOBAP commented 1 year ago

I'm curious, why do we need to move the data-removing command from repos to the support?

I was my mistake because I assumed that all data repos should do data remove before update

It will not do remove anymore

CAMOBAP commented 1 year ago

All data repos doublechecked, and all repos that should keep data directory is keeped and and last commits reverted (for those repos where it was need)