relaton / support

Internal repository support for Relaton
0 stars 0 forks source link

Update crawler workflow to override Gemfile and Gemfile.lock #4

Closed CAMOBAP closed 1 year ago

CAMOBAP commented 1 year ago

After meeting with IETF Team we agreed that:

Also things that don't block ietf-tools team directly are:

@strogonoff feel free to update/comment if I forgot something

CAMOBAP commented 1 year ago

A few PR still left for review but generally crawler workflow is done

Now workflow accept override-files input (added in https://github.com/relaton/support/commit/776c9df4ff58391df6794a0bf857512b021d3bf8)

So you can include it as:

name: Crawler

on:
  push:
    branches: [ master, main ]
    tags: [ v* ]
  pull_request:
  schedule:
  - cron: '0 14 * * *'
  workflow_dispatch:

jobs:
  crawl:
    uses: relaton/support/.github/workflows/crawler.yml@master
    with:
      override-files: |
        https://raw.githubusercontent.com/ietf-tools/bibxml-service/main/Gemfile=Gemfile
        https://raw.githubusercontent.com/ietf-tools/bibxml-service/main/Gemfile.lock=Gemfile.lock

@strogonoff feel free to reopen if you have any comment suggestions

strogonoff commented 1 year ago

@stefanomunarini could you take a look at this too?

stefanomunarini commented 1 year ago

What about the rest of the relaton-data-* repos? @CAMOBAP

CAMOBAP commented 1 year ago

What about the rest of the relaton-data-* repos? @CAMOBAP

Those PRs are merged now, in there is no new data repos created, everything should be up-to-date

P.S. soon I will merge workflow that will monitor newly created repos and notify me to update CI configurations

stefanomunarini commented 1 year ago

Thanks @CAMOBAP .

Does this workflow need to be implemented in relaton-data-ieee (https://github.com/relaton/relaton-data-ieee and https://github.com/ietf-tools/relaton-data-ieee) , relaton-data-nist (https://github.com/relaton/relaton-data-nist), relaton-data-w3c , and all the other data repositories?

And.. when are these workflow ready to be merged into ietf-tools relaton-data-* repos?

Thanks

CAMOBAP commented 1 year ago

@stefanomunarini Sorry for ignore

Does this workflow need to be implemented in relaton-data-ieee (https://github.com/relaton/relaton-data-ieee and https://github.com/ietf-tools/relaton-data-ieee) , relaton-data-nist (https://github.com/relaton/relaton-data-nist), relaton-data-w3c , and all the other data repositories?

AFAIK it's already done for all data repos

And.. when are these workflow ready to be merged into ietf-tools relaton-data-* repos?

Because in ietf-tools you have a requirement to use specific Gemfile you probably should not merge from relaton but use the example which I provided in https://github.com/relaton/support/issues/4#issuecomment-1497095045