search

relaxng / jing-trang

Schema validation and conversion based on RELAX NG
http://www.thaiopensource.com/relaxng/
Other
228 stars 69 forks source link

Implement XML 1.0 Fifth Edition updates to naming. #204

Closed georgebina closed 5 years ago

georgebina commented 8 years ago

Suggested fix for #188 - implements the XML 5th edition updates to allowed naming characters http://www.w3.org/TR/REC-xml/#NT-NameStartChar

georgebina commented 8 years ago

I see that the tests fail after this change... so we need to look into this as well.

georgebina commented 8 years ago

The problems reported by the tests are:

     [java] Failed: /Users/george/Documents/workspace/jing-trang-github/build/mod/rng-validate/test-spec/070/i.rng
     [java] Failed: /Users/george/Documents/workspace/jing-trang-github/build/mod/rng-validate/test-spec/072/i.rng
     [java] Failed: /Users/george/Documents/workspace/jing-trang-github/build/mod/rng-validate/test-spec/073/i.rng
     [java] Failed: /Users/george/Documents/workspace/jing-trang-github/build/mod/rng-validate/test-spec/074/i.rng
     [java] Failed: /Users/george/Documents/workspace/jing-trang-github/build/mod/rng-validate/test-spec/079/i.rng
     [java] Number of tests: 965
     [java] Elapsed time: 781

which seem to check the 0x0e35 as a name start character - and now this is allowed, being in the range [#x37F-#x1FFF] from the NameStartChar production http://www.w3.org/TR/REC-xml/#NT-NameStartChar

[4]     NameStartChar      ::=      ":" | [A-Z] | "_" | [a-z] | [#xC0-#xD6] | [#xD8-#xF6] | [#xF8-#x2FF] | [#x370-#x37D] | [#x37F-#x1FFF] | [#x200C-#x200D] | [#x2070-#x218F] | [#x2C00-#x2FEF] | [#x3001-#xD7FF] | [#xF900-#xFDCF] | [#xFDF0-#xFFFD] | [#x10000-#xEFFFF]
georgebina commented 8 years ago

The commit 863639cc1a9dc58b3217592171dc8d48cc8dca0b removes the failing tests that check the 0x0e35 as a name start character.

sideshowbarker commented 5 years ago

Closing this as stale and still broken per https://github.com/relaxng/jing-trang/pull/204#pullrequestreview-170721526. Easy enough to just reopen if anything changes.