search

relay-tools / react-relay-network-modern-ssr

SSR middleware for react-relay-network-modern
https://github.com/relay-tools/react-relay-network-modern-ssr
MIT License
67 stars 10 forks source link

fix(server): clearTimeout before resolve or reject #15

Closed HsuTing closed 5 years ago

HsuTing commented 5 years ago

When I use react-relay-network-modern-ssr in my component, running jest will get This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with '--detectOpenHandles' to troubleshoot this issue.. The reason cause this problem is that setTimeout block the testing. I think we should clear timeout before resolve or reject.

nodkz commented 5 years ago

Good catch. Thanks!

nodkz commented 5 years ago

:tada: This PR is included in version 1.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: