search

relay-tools / react-relay-network-modern

Relay Modern Network Layer with middlewares — cache, auth, retry, batch, logger, SSR
MIT License
327 stars 62 forks source link

Error should not be thrown on HTTP error when noThrow is set. #123

Open Dirklectisch opened 3 years ago

Dirklectisch commented 3 years ago

I noticed that the noThrow flag only disable throwing for GraphQL errors in the response. For HTTP errors codes coming back from the server an error will be thrown currently even though you set the flag.

In my opinion it makes sense to do the same for HTTP errors in the response. You either handle all the errors yourself or you let the middleware stack throw errors.

tslater commented 2 years ago

I seem to be not having any luck with noThrow, is this still a thing?