search

relay-tools / relay-hooks

Use Relay as React hooks
https://relay-tools.github.io/relay-hooks/docs/relay-hooks.html
MIT License
540 stars 56 forks source link

[relay-hooks 3.7.0 does not work with relay-runtime v10] - networkCacheConfig does not work in useQuery #143

Closed aleksandrlat closed 3 years ago

aleksandrlat commented 3 years ago

networkCacheConfig is passed to fetchQuery here https://github.com/relay-tools/relay-hooks/blob/v3.7.0/src/QueryFetcher.ts#L179-L182

This fetchQuery is internal https://github.com/relay-tools/relay-hooks/blob/v3.7.0/src/QueryFetcher.ts#L14

And fetchQueryInternal does not accept 3rd parameter https://github.com/facebook/relay/blob/master/packages/relay-runtime/query/fetchQueryInternal.js#L105-L108

I don't know why fetchQueryInternal is used. But maybe we should use regular fetchQuery?

Or should we pass networkCacheConfig to createOperationDescriptor here https://github.com/relay-tools/relay-hooks/blob/v3.7.0/src/Utils.ts#L48?

morrys commented 3 years ago

Hi @aleksandrlat, relay-hooks 3.7.0 does not support relay-runtime v10, so you have to look at the fetchQuery at version 9: https://github.com/facebook/relay/blob/v9.1.0/packages/relay-runtime/query/fetchQueryInternal.js#L106-L112

Relay-runtime v10 support is being released with version 4.0.0 https://github.com/relay-tools/relay-hooks/issues/126

Currently version 4.0.0-rc.3 is already available

aleksandrlat commented 3 years ago

@morrys got it. Thank you very much!