[proposal] Add relay-forms in relay-hooks

relay-tools / relay-hooks

Use Relay as React hooks

https://relay-tools.github.io/relay-hooks/docs/relay-hooks.html

MIT License

540 stars 56 forks source link

[proposal] Add relay-forms in relay-hooks #198

Closed morrys closed 1 year ago

morrys commented 2 years ago

issue: https://github.com/relay-tools/relay-hooks/issues/197

The idea is to integrate my relay-forms library into relay-hooks which allows:

dynamic management of form fields
a super performing rendering, taking advantage of all the benefits of relay
Small bundle compared to current libraries to manage forms Documentation: relay-forms

Things to do:

[X] import relay-forms sources into "src/form"
[X] integrate tests
[x] remove RelayForm & useRelayEnvironment in relay-forms, now i can use RelayEnvironmentProvider & useRelayEnvironment from relay-hooks
[ ] update the documentation
[x] integrate sample projects

eMerzh commented 1 year ago

Hey :)

Just came accross this PR... and noticed you didn't got any feedback on your proposal :)

We are user of relay hooks (thanks for the work 🙌 ) ... although you state the bundle size wouldn't change much, not sure what the benefit of including this would be. We won't use this lib as we use another lib for forms, thus we would prefer to keep the side effects as low as possible (like making sure it's treeshakable, not increase install as much as possible, ...

but otherwise the thing looks simple and nice

morrys commented 1 year ago

thanks for the feedback 💯

A few days ago I decided to manage hooks for forms externally

react-relay-forms: it has the official react-relay dependency
relay-forms: depends on relay-hooks, my OSS version of relay hooks
relay-forms-nodeps: it has no dependencies, I only brought the relay functions needed to manage the store into the library, doing a careful cleaning to optimize the bundle size

I proceed to close the PR