relaycc / receiver

Relay Receiver is a React library that makes it easy to add Web3 messaging to your website.
http://www.demo.relay.cc
MIT License
39 stars 2 forks source link

If address has Lens but no ENS, show the Lens in the conversation list instead of 0xaddress #114

Open seanonchain opened 1 year ago

seanonchain commented 1 year ago

Is there an existing issue for this?

Current Behavior

If an address has a lens name but no ENS, we currently show the 0xaddress.

Expected Behavior

Show the Lens handle in the conversation list.

If they have ENS and lens, show the ENS.

Steps To Reproduce

Found in Sean's inbox.

andrewvdp commented 1 year ago

@seanrelay do you have a user that can be used as a test case for this?

seanonchain commented 1 year ago

@seanrelay do you have a user that can be used as a test case for this?

Yes 0x6cb4890d712C91020df2E62FB7BB869CE6Ca3e8A

seanonchain commented 1 year ago
Screen Shot 2022-11-14 at 12 21 40 PM
seanonchain commented 1 year ago

related bug I just noticed is the different avatar blockie / name in the chat.

andrewvdp commented 1 year ago

Just to be clear this is in regard to the conversation list view. The display name should have this priority: ENS name -> lens name -> eth address

seanonchain commented 1 year ago

Yes

BrianS111 commented 1 year ago

related bug I just noticed is the different avatar blockie / name in the chat.

https://github.com/relaycc/receiver/issues/107

I have an issue for it here. Ill get on it soon

BrianS111 commented 1 year ago

@seanwbren Is that one of your accounts? If so can you send me a message so I have one in my conversations list

seanonchain commented 1 year ago

It's not one of mine, can you message them

BrianS111 commented 1 year ago

Oh yeah, That works. I was thinking it was in an individual conversation view, but I messaged them and I see the problem in the conversations list. That should be enough