Closed BrianS111 closed 2 years ago
@BrianS111 Looks good so far. Make sure to remove the package-lock.json
file before marking the PR as ready, the package-lock should never change if the package.json didn't change. Also one other minor thing is that the import 'some-file.css'
only needs to happen once per app, so it probably doesn't need to be in every single component.
I'm slightly surprised that it's just working with css imports, I wonder if the postcss
plugin was previously unnecessary.
Commit / Push made with everything switched away from styled components except components involving: Exports, Props, Animations, nested selectors and svgs, which will be done in the next round.
Commit / Push made with everything switched away from styled components except components involving: Exports, Props, Animations, nested selectors and svgs, which will be done in the next round.
@BrianS111 Looks good. Let me know if any of the cases you listed get weird/tricky.
Status update with recent push: No styled components are left in the project, however the dependency still remains
We should probably do this in multiple PRs if it's going to take more than a day In terms of an implementation plan, let's do things in this order Do a few styled-components that don't take props, check in on how it's going Complete Any styled components that do not take props Complete A few that do take props Complete Check in here Complete The rest Complete
The below section is INCOMPLETE
Achilles will do the last few. The build config might have to happen first, I can help with this if necessary. delete the styled-components dependency! update the build config (how do we bundle CSS with receiver?) update the README w/ new instructions on how to include in project
Closes https://github.com/relaycc/receiver/issues/30
[Note: Pull requests which don't include the minimum details specified in this template will probably be closed out-of-hand.
Issue Link or Description (the "what" and "why")
Implementation Plan
If the pull request is going to be a "Draft" PR for more than a day, authors must include an implementation plan in the form of a checkpoint list.
Implementation Details (the "how")
A detailed description of each change in the changeset. The description should include
How the changeset was tested
A detailed list of cases which the author verified before requesting review.
Changes were verified on the following platforms: