Mobile scrolling when sending a message

relaycc / receiver

Relay Receiver is a React library that makes it easy to add Web3 messaging to your website.

http://www.demo.relay.cc

MIT License

38 stars 2 forks source link

Mobile scrolling when sending a message #91

Closed andrewvdp closed 1 year ago

andrewvdp commented 1 year ago

After sending a message on receiver, messages do not automatically scroll to the last message.

killthebuddh4 commented 1 year ago

@BrianS111 This would be a great ticket for you. I looked into this for a couple hours last night and couldn't fix it.

BrianS111 commented 1 year ago

I'm on it!

killthebuddh4 commented 1 year ago

@andrewvdp This issue is a Receiver issue.

BrianS111 commented 1 year ago

Just to make sure we are on the same page.. when I'm at the bottom of a convo, it does show that last message sent after sending. So what we are looking for here is if you're scrolled up maybe halfway through a conversation, and you send a message, you want it to scroll to the bottom? I thought that was functionality we were trying to avoid so sending a message doesn't disrupt reading old messages etc....

killthebuddh4 commented 1 year ago

It might be that it's working on Android but not on iOS.

Expected:

If you're scrolled all the way to the bottom of the messages list, and a new message arrives, then you should remain scrolled to the bottom of the messages list

Current on iOS Safari:

Scroll all the way to the bottom of the messages list
Send a message
The new message will show up hidden beneath the input field and the user will have to scroll to see it

killthebuddh4 commented 1 year ago

@BrianS111 To test on iOS, I'm using XCode Device Simulator. XCode is the official Apple IDE, you can download it on the app store. It's not super duper fast, but it's way faster than both BrowserStack and ngrok IME.

seanonchain commented 1 year ago

if you're scrolled up maybe halfway through a conversation, and you send a message, you want it to scroll to the bottom?

Yes this is normal behavior.

killthebuddh4 commented 1 year ago

When you send a message it should scroll, but it probably shouldn't scroll when any message comes in.

BrianS111 commented 1 year ago

if you're scrolled up maybe halfway through a conversation, and you send a message, you want it to scroll to the bottom?

Yes this is normal behavior.

FEDDC371-8B57-4AD3-860A-B00D6DB34256_4_5005_c

DIscord only scrolls you back down if you are viewing recent messages, if you are viewing older messages it keeps you where you are. A bit more advanced than doing it one way, but possible

killthebuddh4 commented 1 year ago

We don't need to worry about that, just use whether or not the user is scrolled at all.

If the user sends a message, scroll to the bottom
If the user receives a message, and they are already scrolled all the way down, the message should be visible without additional scrolling
If the user receives a message, and they aren't already scrolled all the way down, do nothing

BrianS111 commented 1 year ago

** Current on iOS Safari:

Scroll all the way to the bottom of the messages list Send a message The new message will show up hidden beneath the input field and the user will have to scroll to see it **

Quoting from above

I can't reproduce this. I used safari on Iphone from the old one we have in the office.. set messages immediately, waited the 5 min it takes to be a new bubble etc. After lunch I'll get on the orig issue of scrolling to the bottom after sending

BrianS111 commented 1 year ago

The solution I have for the scrolling down when scrolled up thing will probably fix any issues anyone has with scrolling after sending though

killthebuddh4 commented 1 year ago

@BrianS111 @andrewvdp

Here's a video of the only bug that needs to be fixed, the other items are less important. That said, if this bug is fixed I think the others should follow pretty easily.

https://user-images.githubusercontent.com/100799178/195193785-ffd6507b-06b2-4c56-904e-598fa8c5afbf.mov